Skip to content

Linking directly to a new version from the front page shows no downloads #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jtgeibel opened this issue Jan 18, 2020 · 3 comments
Closed

Comments

@jtgeibel
Copy link
Member

Under #1931 we made the decision to link directly from the front page to a version if we were showing that version number in parenthesis next to the crate name. This seemed like a reasonable change to make at the time, but in retrospect it can cause confusion. (In fact I confused myself because I just deployed a change, and wasn't sure why I wasn't seeing any downloads when clicking on crates from the front page.)

When clicking on a link under "Just Updated", you are taken directly to the newest version of that crate. Because that version was just published, it will not have any downloads. Even if the crate has old versions which are frequently downloaded, the version specific page shows only the downloads for that version. This is unfortunate, because the "Just Updated" links are prominent on the front page and clicking on them gives the immediate impression that a crate has no history of downloads.

This issue is confounded by the fact that there is no easy way to navigate from a specific version of a crate, to the overview page for the crate. These pages look almost identical, with the only differences I can see being the exact contents of the readme, and the download graph.

Proposed solution

We should update the front page components to point to the crate overview pages like we did previously. Optionally, we should provide an easy and prominent way to navigate from a version page back to the crate overview page. We could also make it clearer on the version page that the graph is showing download for that version only.

This would be a great first PR if anyone is interested.

@Zexbe
Copy link
Contributor

Zexbe commented Jan 21, 2020

Ok, I'm going to try. Thank you for being so detailed.

@Zexbe
Copy link
Contributor

Zexbe commented Jan 21, 2020

I am done.
The contribution steps didn't work for me, so I had to do figure out some extra steps to make npm work:
npm config set script-shell "C:\\Program Files\\git\\bin\\bash.exe
npm install -g ember-cli

bors added a commit that referenced this issue Jan 25, 2020
Resolves issue 2143

I made three changes to improve the experience.

    The homepage links go to the overview instead of a specific version
    I added the version next to the stats, so you can tell what they are for.
    I added a link back to the overview page next to the stats.

On the overview page it looks like this "Stats Overview"
On a specific version it looks like this "Stats Overview for 0.2.4 (see all)"

Resolves issue #2143

Remaking to run job again
@Turbo87
Copy link
Member

Turbo87 commented Jan 29, 2020

Resolved by #2155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants