Skip to content

Rewrite the arm mem* builtins without asm and naked functions #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2016

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Aug 8, 2016

This also fixes the calling convention on those functions, which should be "aapcs" instead of "C".

@japaric
Copy link
Member

japaric commented Aug 8, 2016

Nice! I first tried to implement these function like this but I got an extra bl (or was it bx?) instruction at the end of each routine; that may have been caused by the calling convention I used: "C" instead of "aapcs".

@japaric japaric merged commit b7a9d45 into rust-lang:master Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants