Add a default template for Cargo.toml #5782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like cargo traverses the filesystem & fails if it runs into a Cargo.toml that doesn't declare a target. I couldn't find a nice way to re-engineer the test to avoid this issue. So I'll leave that as someone else's exercise.
|
@bors: r+ Awesome, thanks so much! |
|
📌 Commit 081e793 has been approved by |
|
⌛ Testing commit 081e793 with merge 25f33c2a01af74d2e4546ad16b714079678e4fa9... |
|
💔 Test failed - status-travis |
|
I think(?) the test failure is spurious as I don't even touch |
|
I think the error is the same as #5482. I think that |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Jul 24, 2018
Add a default template for Cargo.toml Fixes #5743 r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5743
r? @alexcrichton