Test for #3419 #3426
Merged
Test for #3419 #3426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| authors = [] | ||
|
|
||
| [dependencies] | ||
| rustc-serialize = "*" |
There was a problem hiding this comment.
Ah yeah we probably want to avoid downloading rustc-serialize here. If you look around in the test suite for Package::new though you'll see a way to shim the registry with a local copy and quickly create something locally.
There was a problem hiding this comment.
Also out of curiosity, what was the bug here? Did fixing the profiles fix it? If so that seems odd...
Unless we picked up the in-tree copy of rustc-serialize... oh dear...
|
Now with offline test |
Includes adding facility for checking that output does not contain a string.
|
@bors: r+ |
|
📌 Commit 129ce53 has been approved by |
|
⌛ Testing commit 129ce53 with merge 8babe9c... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
…On Sun, Dec 25, 2016 at 6:44 PM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang-libs/cargo/build/1.0.707>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#3426 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95I8vOuKMdfOECXm1OkbNHb0Wuk1lks5rLyomgaJpZM4LQQYQ>
.
|
bors
added a commit
that referenced
this pull request
Dec 26, 2016
Test for #3419 Based on top of #3425. I'm not sure if this is an acceptable test because it downloads rustc-serialize. r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Dec 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #3425.
I'm not sure if this is an acceptable test because it downloads rustc-serialize.
r? @alexcrichton