Fix expected output in build-std test
#14353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
weihanglo
reviewed
Aug 5, 2024
| @@ -114,6 +114,7 @@ fn basic() { | |||
| // Importantly, this should not say [UPDATING] | |||
| // There have been multiple bugs where every build triggers and update. | |||
| .with_stderr_data(str![[r#" | |||
| [UPDATING] crates.io index | |||
There was a problem hiding this comment.
Looked a few lines above
// Importantly, this should not say [UPDATING]
// There have been multiple bugs where every build triggers and update.
Before proceeding, we may want to figure out what has changed and if it is safe to update index.
There was a problem hiding this comment.
Perhaps rust-lang/rust#128534, though I may not have time looking into it today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent nightly update caused one of the
build-testtests (basic) to fail, due to changed output. A few CI builds failed for this reason, for example here or here.This change updates the expected
stdoutoutput to include the missing line.