Skip to content

Add explicit dependency on regex. #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2015
Merged

Add explicit dependency on regex. #1227

merged 1 commit into from
Jan 26, 2015

Conversation

retep998
Copy link
Member

Fixes the following issue while building Cargo

   Compiling cargo v0.1.0 (file:///C:/msys64/home/Peter/cargo)
src\cargo\lib.rs:7:1: 7:20 error: can't find crate for `regex`
src\cargo\lib.rs:7 extern crate regex;
                   ^~~~~~~~~~~~~~~~~~~
error: aborting due to previous error
Could not compile `cargo`.

@rust-highfive
Copy link

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@ghost
Copy link

ghost commented Jan 26, 2015

confirmed happens with:
rustc 1.0.0-dev (43046becc 2015-01-25 05:50:30 +0000)
but not with
rustc 1.0.0-nightly (4be79d6ac 2015-01-23 16:08:14 +0000)

due to this: rust-lang/rust#21458

@huonw
Copy link
Member

huonw commented Jan 26, 2015

@bors: r+ 1943978

bors added a commit that referenced this pull request Jan 26, 2015
Fixes the following issue while building Cargo
```
   Compiling cargo v0.1.0 (file:///C:/msys64/home/Peter/cargo)
src\cargo\lib.rs:7:1: 7:20 error: can't find crate for `regex`
src\cargo\lib.rs:7 extern crate regex;
                   ^~~~~~~~~~~~~~~~~~~
error: aborting due to previous error
Could not compile `cargo`.
```
@bors
Copy link
Contributor

bors commented Jan 26, 2015

⌛ Testing commit 1943978 with merge e20caae...

@bors
Copy link
Contributor

bors commented Jan 26, 2015

☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64

@bors bors merged commit 1943978 into rust-lang:master Jan 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants