Skip to content

Cannot compile for musl because of missing libc::NFS_SUPER_MAGIC #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jirutka opened this issue Jul 31, 2016 · 3 comments
Closed

Cannot compile for musl because of missing libc::NFS_SUPER_MAGIC #2937

jirutka opened this issue Jul 31, 2016 · 3 comments

Comments

@jirutka
Copy link
Contributor

jirutka commented Jul 31, 2016

libc crate does not provide NFS_SUPER_MAGIC for musl libc (don’t know why). This constant is used in cargo/util/flock:295.

@alexcrichton
Copy link
Member

I'd be fine with either just not executing this check on musl or hardcoding the value of NFS_SUPER_MAGIC, it looks like musl doesn't have a definition for that in its header files.

@jirutka
Copy link
Contributor Author

jirutka commented Aug 6, 2016

To be honest, I have no clue what implications it may have when you hard-code that value, so the decision is up to you. I’ve simply disabled that check in Alpine package for cargo.

@alexcrichton
Copy link
Member

Yeah that's fine, do you want to upstream that as well? I'd be more than fine taking a PR for that!

bors added a commit that referenced this issue Aug 7, 2016
Disable is_on_nfs_mount() check on musl libc (fixes #2937)

musl libc doesn't provide constant NFS_SUPER_MAGICK that is used in the is_on_nfs_mount function.
@bors bors closed this as completed in a7f4745 Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants