Attempt to backtrace through jit frames on x86_64 Windows #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
windows-x86-64-jit
branch
from
b85f78c to
c8c8184
Compare
7 tasks
alexcrichton
force-pushed
the
windows-x86-64-jit
branch
from
c8c8184 to
8ff78c3
Compare
alexcrichton
force-pushed
the
windows-x86-64-jit
branch
from
8ff78c3 to
6d2337e
Compare
|
@peterhuene mind double-checking me on this? |
peterhuene
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
LGTM!
@yurydelendik was this change tested with tracing through JIT frames?
peterhuene
reviewed
Jan 15, 2020
| // dbghelp for getting the function table and module base. Instead we use | ||
| // the `RtlLookupFunctionEntry` function in kernel32 which will account for | ||
| // JIT compiler frames as well. These should be equivalent, but using | ||
| // `Rtl*` allows us to backtrace through JIT frames. |
There was a problem hiding this comment.
Just thinking that we should perhaps mention that this is limited to in-process walking only, which is fine for backtrace's use case.
|
@yurydelendik never mind, I missed the earlier comment by @alexcrichton regarding testing these changes with your PR! |
|
Note: This pushes the minimum Rust version to 1.38 due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being developed in conjunction with bytecodealliance/wasmtime#759 and should allow
x86_64-pc-windows-*to natively backtrace through JIT frames