Fix some cases of concurrent panics and backtraces #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sfackler mind double-checking me on this logic and this patch? This doesn't actually affect the standard library at all, just the crates.io version of this crate. I'm curious to get your take on this strategy and the general problem as well |
alexcrichton
force-pushed
the
concurrent-panics
branch
from
98af75d to
2b6a75b
Compare
This commit adds an awful hack to this crate to attempt to mitigate the issue of concurrently generating a backtrace in the standard library via `RUST_BACKTRACE=1` and also generating a backtrace with this crate. On Windows the system library that we used for doing this is required to be single-threaded but we don't actually provide such a guarantee when using this crate because we can't easily synchronize with the standard library. The hack applied in this crate is to use a *panic hook* to inject ourselves into the panic process and ensure that panics are synchronized with generating a backtrace. The commit itself has a lot more comments about how this is not a complete nor a bullet-proof solution. It's just sort of the best approximation I think we can do with stable Rust. Long-term we're going to want to have some sort of official stable API in libstd to do this coordination.
alexcrichton
force-pushed
the
concurrent-panics
branch
from
2b6a75b to
2d9854a
Compare
|
How about using a session-scoped named lock to synchronize between std's backtrace and the normal backtrace? https://docs.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-createmutexa |
|
Wow that's a way better idea, nice thinking! I'll implement that soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an awful hack to this crate to attempt to mitigate the
issue of concurrently generating a backtrace in the standard library via
RUST_BACKTRACE=1and also generating a backtrace with this crate. OnWindows the system library that we used for doing this is required to be
single-threaded but we don't actually provide such a guarantee when
using this crate because we can't easily synchronize with the standard
library.
The hack applied in this crate is to use a panic hook to inject
ourselves into the panic process and ensure that panics are synchronized
with generating a backtrace. The commit itself has a lot more comments
about how this is not a complete nor a bullet-proof solution. It's just
sort of the best approximation I think we can do with stable Rust.
Long-term we're going to want to have some sort of official stable API
in libstd to do this coordination.
cc #230