safe &'static mut references through a runtime checked macro
#70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, I'm not too hot about the name |
Me neither.
Sounds better to me. Please continue bikeshedding :-). |
hannobraun
reviewed
Dec 24, 2017
src/macros.rs
Outdated
| @@ -22,3 +22,44 @@ macro_rules! iprintln { | |||
| iprint!($channel, concat!($fmt, "\n"), $($arg)*); | |||
| }; | |||
| } | |||
|
|
|||
| /// Macro to create an statically allocated value | |||
There was a problem hiding this comment.
Should be "a statically allocated value", I think?
src/macros.rs
Outdated
| /// | ||
| /// # Example | ||
| /// | ||
| /// ``` ignore |
There was a problem hiding this comment.
It should be possible to un-ignore this example by adding this to the beginning:
# #[macro_use] extern crate cortex_m;
// rest of example
It still won't run, because of the deliberate panic, but the ignore can be replaced with no_run, which will at least will make sure that the example can be compiled.
|
OK, thanks everyone for the feedback. Let's go ahead with @homunkulus r+ |
|
📌 Commit 4f9664c has been approved by |
japaric
pushed a commit
that referenced
this pull request
Jan 15, 2018
safe `&'static mut` references through a runtime checked macro runtime checked implementation of japaric/cortex-m-rtfm#59 that doesn't depend on RTFM macros TODO - [ ] bikeshed macro syntax
|
☀️ Test successful - status-travis |
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
to make it more compatible with LLD. This commit contains no functional changes. fixes #70 Overview of changes: - Alignment checks are enabled now that rust-lld (LLD 7.0) supports the modulo operator. - Removed some private symbols (e.g. __foo) in favor of ADDR and SIZEOF. - Turned .got into a NOLOAD section now that rust-lld supports it. - Replaced `ABSOLUTE(.)` with `.` as an old LLD overlap bug seems to be gone and ABSOLUTE seems to cause problems, like #70, on bigger programs. - Made the linker assertion messages more uniform. - Extended test suite to check that linking works with both rust-lld and GNU LD.
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
84: refactor the linker script r=therealprof a=japaric to make it more compatible with LLD. This commit contains no functional changes. fixes #70 Overview of changes: - Alignment checks are enabled now that rust-lld (LLD 7.0) supports the modulo operator. - Removed some private symbols (e.g. __foo) in favor of ADDR and SIZEOF. - Turned .got into a NOLOAD section now that rust-lld supports it. - Replaced `ABSOLUTE(.)` with `.` as an old LLD overlap bug seems to be gone and ABSOLUTE seems to cause problems, like #70, on bigger programs. - Made the linker assertion messages more uniform. - Extended test suite to check that linking works with both rust-lld and GNU LD. r? therealprof (chosen at random) Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime checked implementation of japaric/cortex-m-rtfm#59 that doesn't depend on RTFM macros
TODO