-
Notifications
You must be signed in to change notification settings - Fork 288
Add tests for no-std #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for no-std #173
Conversation
db3e082
to
0b6345a
Compare
0b6345a
to
e5e22ee
Compare
Can you clarify the motivation for this PR? |
@apoelstra Yes, #172. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice. Approach ACK. I think it would be helpful to add a few sentences of documention (by adding a header main.rs
?) mentioning what this is (a minimal nostd example that exercises some secp functions and features) and the kinds of error messages expected when something accidentally pulls in std
.
cdf538f
to
49391d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. Looks great.
This will not compile if std is somehow involved.
You can see yourself by removing
default-features = false
from the Cargo.toml and you'll get:This currently only runs in release mode due to a bug that debug mode always tries to link to libunwind (which isn't available) even when we use abort instead of panic.