[ntuple] Remove unused private REntry methods
#18675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was originally added to be used by the `RNTupleProcessor`, but is not used there anymore. Since it is a private method and has no uses anywhere else in the code base, there's no reason to keep it around.
This method was originally added to be used by the `RNTupleProcessor`, but is not used there anymore. Since it is a private method and has no uses anywhere else in the code base, there's no reason to keep it around.
vepadulano
approved these changes
May 9, 2025
hahnjo
approved these changes
May 9, 2025
Already have this ready in a related PR coming up soon 👍. |
Test Results 19 files 19 suites 4d 2h 11m 6s ⏱️ Results for commit 029eb4a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
UpdateValueandGetValuewere originally added to be used by theRNTupleProcessor, but are not used there anymore. Since they are private methods and have no uses anywhere else in the code base, there's no reason to keep them around.