Skip to content

Disable syntax benchmark warnings in PRs for now #7380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 29 additions & 27 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -373,33 +373,35 @@ jobs:
if: matrix.benchmarks
run: ./_build/install/default/bin/syntax_benchmarks | tee tests/benchmark-output.json

- name: Restore previous benchmark data
if: matrix.benchmarks
uses: actions/cache/restore@v4
with:
path: ./tests/benchmark-cache
key: syntax-benchmark-v1

- name: Create new benchmark data and comment on alert
# Do not run for PRs created from other repos as those won't be able to write to the pull request
if: ${{ matrix.benchmarks && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.event.repository.full_name) }}
uses: benchmark-action/github-action-benchmark@v1
with:
name: Syntax Benchmarks
tool: customSmallerIsBetter
output-file-path: tests/benchmark-output.json
external-data-json-path: ./tests/benchmark-cache/benchmark-data.json
github-token: ${{ secrets.GITHUB_TOKEN }}
alert-threshold: "105%"
comment-always: false
comment-on-alert: true

- name: Save benchmark data as new baseline
if: matrix.benchmarks && github.ref == 'refs/heads/master'
uses: actions/cache/save@v4
with:
path: ./tests/benchmark-cache
key: syntax-benchmark-v1
# Benchmarking is disabled for now because of inconsistent run times on different runners
#
# - name: Restore previous benchmark data
# if: matrix.benchmarks
# uses: actions/cache/restore@v4
# with:
# path: ./tests/benchmark-cache
# key: syntax-benchmark-v1

# - name: Create new benchmark data and comment on alert
# # Do not run for PRs created from other repos as those won't be able to write to the pull request
# if: ${{ matrix.benchmarks && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.event.repository.full_name) }}
# uses: benchmark-action/github-action-benchmark@v1
# with:
# name: Syntax Benchmarks
# tool: customSmallerIsBetter
# output-file-path: tests/benchmark-output.json
# external-data-json-path: ./tests/benchmark-cache/benchmark-data.json
# github-token: ${{ secrets.GITHUB_TOKEN }}
# alert-threshold: "105%"
# comment-always: false
# comment-on-alert: true

# - name: Save benchmark data as new baseline
# if: matrix.benchmarks && github.ref == 'refs/heads/master'
# uses: actions/cache/save@v4
# with:
# path: ./tests/benchmark-cache
# key: syntax-benchmark-v1

- name: Build playground compiler
if: matrix.build_playground
Expand Down