Upgrade dune version to get WASM binary #7349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
reviewed
Mar 18, 2025
cometkim
force-pushed
the
dune-wasm
branch
3 times, most recently
from
251dd7b to
f376368
Compare
cometkim
force-pushed
the
dune-wasm
branch
2 times, most recently
from
277f7f6 to
9c49689
Compare
cometkim
force-pushed
the
dune-wasm
branch
2 times, most recently
from
a544ca7 to
601d2f6
Compare
|
The WASM compiler failed to be installed on Windows. However, we don't perform JSOO tests on Windows. So I think it's better to skip Since conditional dependency is not supported in the dune syntax, we had to move the dependency management to the opam template. This is also the method that the dune project uses itself. |
cknitt
approved these changes
Mar 26, 2025
|
|
||
| if (process.platform !== "win32") { | ||
| child_process.execSync(`strip ${dest}`); | ||
| let mode = 0o755; |
There was a problem hiding this comment.
Why are the permission-related changes required now?
There was a problem hiding this comment.
They don't give write permission anymore. binaries are r+x.
The script is to grant required permissions before the task and to revoke them after it is completed.
fhammerschmidt
pushed a commit
that referenced
this pull request
Apr 4, 2025
* upgrade dune version to get WASM build * suppress warnings in corrected way * fix permission issues * format * install js_of_ocaml-ppx * fix * fix playground test * manage dependency list in opam template * fix opam cache key to use opam
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.