Test ast conversion #7318
Merged
Test ast conversion #7318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, though I think this would apply to a new dir for ppx tests, so not to interfere with ordinary print test. |
|
Yes, I shoved it in the existing test to try out the mechanism. |
Probably a new directory. |
nojaf
force-pushed
the
ast-conversion-tests
branch
from
aad1fc9 to
c6d9537
Compare
|
Alright, I think these new tests will verify the conversion for the jsx ast. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cristianoc would this be the additional mapping test you had in mind?