Skip to content

Support universal dot completion in editor tooling #7226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 4, 2025
Merged

Support universal dot completion in editor tooling #7226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
625c60c
Port PR from rescript-vscode
nojaf Jan 3, 2025
e4d3f7d
Run all tests locally
nojaf Jan 4, 2025
12d0057
Revert changes in CompletionBackEnd and TypeUtils
nojaf Jan 4, 2025
f67ac21
Revert CompletionFrontEnd.ml
nojaf Jan 4, 2025
489569f
Remove some unnecessary recs
nojaf Jan 4, 2025
a87aef9
Whoops
nojaf Jan 4, 2025
173c178
Add changelog entry
nojaf Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#### :house: Internal

- AST cleanup: use inline record for Pexp_fun. https://github.com/rescript-lang/rescript/pull/7213
- Add support for "dot completion everywhere" (Ported from https://github.com/rescript-lang/rescript-vscode/pull/1054). https://github.com/rescript-lang/rescript/pull/7226

#### :nail_care: Polish

Expand Down
2 changes: 1 addition & 1 deletion analysis/src/Codemod.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ let transform ~path ~pos ~debug ~typ ~hint =
if debug then print_endline "Found no result";
exit 1
| Some switchExpr ->
printExpr ~range:(Xform.rangeOfLoc switchExpr.pexp_loc) switchExpr)
printExpr ~range:(Loc.rangeOfLoc switchExpr.pexp_loc) switchExpr)
| _ ->
if debug then print_endline "Mismatch in expected structure";
exit 1)
Loading
Loading