Cherry pick fixes for 11.1.3 #6913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Jul 26, 2024
zth
approved these changes
Jul 26, 2024
|
Is this one out of the question? #6907 |
Signed-off-by: Alex Kocharin <[email protected]>
Turns out that `@uncurry` attribute even in uncurried mode can produce js code that used`Curry`. The `@uncurry` attribute will be deprecated. For now, this PR ignores it.
…unctions.
A function such as this one:
```
let t4 = ({contents: x0}, {contents: x1}, {contents: x2}, {contents: x3}) => (x0, x1, x2, x3)
```
is 4 nested functions each one extracting the `contents` field.
In uncurried mode, the arity is adjusted to be 4, by putting a wrapper on top.
The wrapper was added by applying all the new args at once, which requires `Curry` runtime.
* force regenerate build.ninja * fix bin path * Update CHANGELOG.md * force regenerate when `warn-error` argument change * restore `-regen` argument * regenerate if previous warn error != 0 # Conflicts: # CHANGELOG.md
|
Will not include the JSBigInt payload type change as it breaks third party packages (e.g. rescript-schema 6). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked fixes for 11.1.3 which I would like to release before 12.0.0-alpha.1.
This includes some of @cristianoc's uncurried cleanup work.
@cristianoc Could you have a look to see if these commits are ok to include (and if there are any additional ones that I should include)?