Skip to content

add Deno as a reserved name #6428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 12, 2023
Merged

add Deno as a reserved name #6428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
050b6d4
add `Deno` as a reserved name
cometkim Oct 10, 2023
eb18d23
[skip ci] add CHANGELOG
cometkim Oct 10, 2023
f3264a7
Merge branch 'master' into deno-global
cometkim Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
- Fix issue with Dynamic import of module in nested expressions https://github.com/rescript-lang/rescript-compiler/pull/6431
- Fix issue where GenType was not supporting `@tag` on ordinary variatns https://github.com/rescript-lang/rescript-compiler/pull/6437

#### :nail_care: Polish

- Add [`Deno`](https://deno.land/api?s=Deno) to reserved names, so that modules named `Deno` don't clash with the globally exposed `Deno` object. https://github.com/rescript-lang/rescript-compiler/pull/6428

# 11.0.0-rc.4

#### :rocket: New Feature
Expand Down
1 change: 1 addition & 0 deletions jscomp/ext/js_reserved_map.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ let sorted_keywords = [|
"DecompressionStream";
"DelayNode";
"DelegatedInkTrailPresenter";
"Deno";
"Document";
"DocumentFragment";
"DocumentPictureInPictureEvent";
Expand Down
7 changes: 5 additions & 2 deletions scripts/build_reserved.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

let reserved_words =
[|
(* keywork *)
(* keywords *)
"break";
"case"; "catch"; "continue";
"debugger";"default";"delete";"do";
Expand Down Expand Up @@ -130,7 +130,10 @@
"__esModule";

(* Bun global obj *)
"Bun"
"Bun";

(* Deno global obj *)
"Deno";
|]


Expand Down