Skip to content

Consistency in unsafe function names #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aspeddro opened this issue Jun 3, 2024 · 0 comments · Fixed by rescript-lang/rescript#7337
Closed

Consistency in unsafe function names #225

aspeddro opened this issue Jun 3, 2024 · 0 comments · Fixed by rescript-lang/rescript#7337
Assignees
@tsnobip

Comments

@aspeddro
Copy link
Contributor

aspeddro commented Jun 3, 2024

I saw that most unsafe functions are ModName.somethingUnsafe, unsafe is a suffix, but in module String we have the inverse unsafeReplaceRegExpBy0, unsafeReplaceRegExpBy1

Just a reminder to stay consistent
@tsnobip tsnobip self-assigned this Mar 7, 2025
tsnobip added a commit to rescript-lang/rescript that referenced this issue Mar 13, 2025
@tsnobip
make unsafe function names consistent
9b7e235 
Fixes rescript-lang/rescript-core#225
@tsnobip tsnobip mentioned this issue Mar 13, 2025
Merged
tsnobip added a commit to rescript-lang/rescript that referenced this issue Mar 13, 2025
@tsnobip
make unsafe function names consistent
ac6b638 
Fixes rescript-lang/rescript-core#225
tsnobip added a commit to rescript-lang/rescript that referenced this issue Mar 13, 2025
@tsnobip
make unsafe function names consistent
8168641 
Fixes rescript-lang/rescript-core#225
fhammerschmidt pushed a commit to rescript-lang/rescript that referenced this issue Apr 4, 2025
@tsnobip @fhammerschmidt
make unsafe function names consistent (#7337)
187a0eb 
Fixes rescript-lang/rescript-core#225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsnobip tsnobip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make unsafe function names consistent rescript-lang/rescript
2 participants
@tsnobip @aspeddro