Replace is_proper_subtype(...) with is_subtype(..., proper=True)
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: mypy (https://github.com/python/mypy)
+ mypy_self_check.ini:20: error: Error importing plugin "misc/proper_plugin.py": cannot import name 'is_proper_subtype' from 'mypy.subtypes' (/tmp/mypy_primer/new_mypy/venv/lib/python3.10/site-packages/mypy/subtypes.py) [misc]
|
relsunkaev
force-pushed
the
refactor/3297-combine-subtype-checks
branch
from
de90003 to
9d63fa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes python#3297
Absorbed
is_proper_subtypeintois_subtypeto remove a lot of code duplication. Now, when invoked withproper=True,is_subtypeperforms a proper subtype check. It now also accepts all parameters thatis_proper_subtypedid.Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Ran the full test suite on python 3.6 through 3.10