Skip to content

Translate thinking-in-react.md #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

rammba
Copy link
Collaborator

@rammba rammba commented Sep 23, 2024

I've added translation for thinking-in-react.md. Feel free to add suggestions and comments.

Closes #77

@rammba rammba requested a review from lxmarinkovic September 23, 2024 16:21
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


<ConsoleBlock level="error">

You provided a \`value\` prop to a form field without an \`onChange\` handler. This will render a read-only field.

</ConsoleBlock>

In the sandbox above, `ProductTable` and `SearchBar` read the `filterText` and `inStockOnly` props to render the table, the input, and the checkbox. For example, here is how `SearchBar` populates the input value:
<ConsoleBlock level="error">
Copy link
Collaborator Author

@rammba rammba Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added new console block to show translated message also. Is this correct way, or we can use something else?
I would like to keep the original message as well, because it's shown in the sandbox probably due to react compiler.

Examples on other languages:
image

image

image

image

Copy link
Collaborator

@lxmarinkovic lxmarinkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but one thing before I merge this. I have decided not to translate the word "component" as one of react terms and keep it as it is or hyphenated when necessary. The logic behind this is to avoid any ambiguities when we have the Serbian word "komponenta" necessary in translation since it would keep straight (as this document says) thinking in react. Pleease let me know your thoughts on this :D

@rammba
Copy link
Collaborator Author

rammba commented Sep 24, 2024

For me it's more fluid to use komponenta instead of component. I would like to read these docs in the same way as I would say something to my colleague everyday.
For example: I would rather say "Trebali bi da pomerimo onaj input u Button komponentu.", instead of "Trebali bi da pomerimo onaj input u Button component."
I know that component is widely known term in many frameworks, not only React, but I would stick with translated term.

@lxmarinkovic
Copy link
Collaborator

For me it's more fluid to use komponenta instead of component. I would like to read these docs in the same way as I would say something to my colleague everyday.

For example: I would rather say "Trebali bi da pomerimo onaj input u Button komponentu.", instead of "Trebali bi da pomerimo onaj input u Button component."

I know that component is widely known term in many frameworks, not only React, but I would stick with translated term.

In my opinion you got the point but "Trebalo bi da pomerimo onaj input u Button component-u" would sound the same but avoiding possible ambiguities. I both ways the word is Latin not English, not Serbian… If you more ideas why this should be better we can discuss it on discord :D

@lxmarinkovic lxmarinkovic merged commit 1e9e0d2 into main Sep 24, 2024
3 checks passed
@lxmarinkovic lxmarinkovic deleted the features/thinking-in-react branch September 24, 2024 17:57
@rammba rammba mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thinking in React
2 participants