-
Notifications
You must be signed in to change notification settings - Fork 4
Translate thinking-in-react.md #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
||
<ConsoleBlock level="error"> | ||
|
||
You provided a \`value\` prop to a form field without an \`onChange\` handler. This will render a read-only field. | ||
|
||
</ConsoleBlock> | ||
|
||
In the sandbox above, `ProductTable` and `SearchBar` read the `filterText` and `inStockOnly` props to render the table, the input, and the checkbox. For example, here is how `SearchBar` populates the input value: | ||
<ConsoleBlock level="error"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but one thing before I merge this. I have decided not to translate the word "component" as one of react terms and keep it as it is or hyphenated when necessary. The logic behind this is to avoid any ambiguities when we have the Serbian word "komponenta" necessary in translation since it would keep straight (as this document says) thinking in react. Pleease let me know your thoughts on this :D
For me it's more fluid to use |
In my opinion you got the point but "Trebalo bi da pomerimo onaj input u Button component-u" would sound the same but avoiding possible ambiguities. I both ways the word is Latin not English, not Serbian… If you more ideas why this should be better we can discuss it on discord :D |
I've added translation for
thinking-in-react.md
. Feel free to add suggestions and comments.Closes #77