Skip to content

fix: align not scrollable #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: align not scrollable #419

merged 1 commit into from
Aug 14, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 14, 2023

测量的时候创建一个占位元素把原本的位置顶住,测量完删除。

PS:这个在 jsdom 里无法测试出效果。

fix ant-design/ant-design#44196

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #419 (17535fb) into master (b4d92bf) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 17535fb differs from pull request most recent head 769f67f. Consider uploading reports for the commit 769f67f to get more accurate results

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   97.03%   97.06%   +0.03%     
==========================================
  Files          13       13              
  Lines         776      784       +8     
  Branches      229      229              
==========================================
+ Hits          753      761       +8     
  Misses         23       23              
Files Changed Coverage Δ
src/hooks/useAlign.ts 97.67% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit 49555a0 into master Aug 14, 2023
@zombieJ zombieJ deleted the fix-placeholder branch August 14, 2023 11:15
placeholderElement.style.top = `${popupElement.offsetTop}px`;
placeholderElement.style.position = popupPosition;
placeholderElement.style.height = `${popupElement.offsetHeight}px`;
placeholderElement.style.width = `${popupElement.offsetWidth}px`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个能用 assign 代替吗?

@mellis481
Copy link

@zombieJ @yoyo837 It looks like this PR is the cause of #496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip Scroll Behavior Issue with Long Text Extending Beyond Viewport Height
3 participants