Drop deprecated HiPE compilation #2392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Fenoll <[email protected]>
|
@fenollp Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@fenollp Thank you for signing the Contributor License Agreement! |
michaelklishin
requested changes
Jun 24, 2020
There was a problem hiding this comment.
Thank you, I think it's the right thing to do at this point. The docs have been saying the following about HiPE for over a year now:
HiPE support has been dropped in Erlang 22. RabbitMQ no longer supports HiPE precompilation.
We must retain the configuration schema key. There's also a CLI command which we should mark as deprecated similarly to this command and also made a no-op.
Signed-off-by: Pierre Fenoll <[email protected]>
|
Great contribution, 👍 from me, thanks! |
|
This looks good. I will take care of the |
michaelklishin
approved these changes
Jun 25, 2020
michaelklishin
added a commit
to rabbitmq/rabbitmq-cli
that referenced
this pull request
Jun 25, 2020
HiPE has been deprecated/only partially supported in Erlang 22 and will be removed completely in Erlang 24 next year. Part of rabbitmq/rabbitmq-server#2392
michaelklishin
changed the title
|
Thank you! |
michaelklishin
added a commit
that referenced
this pull request
Jun 25, 2020
drop deprecated HiPE compilation (cherry picked from commit b7cbd44)
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove all handling of OTP's HiPE AOT optimizer that was deprecated, is unusable since OTP22 and is going to be removed in OTP24
I'm unsure what the minimum supported OTP release is however the Docker images already use OTP23 (which cannot make use of HiPE).
I left uses of
$RABBITMQ_SERVER_CODE_PATHin scripts/ as it is unclear if anything other than HiPE is concerned about-pa.Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.