[revealjs] pin to commit hash version to get fix on slide scaling #2437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JS lib Current version use `zoom` attributes which messes up JS lib like plotly. This new version using `scale()` transform only. Fixes #2430
4 tasks
|
This is probably going to fix our mermaid tooltips issue as well!! <3 |
|
Cool ! hopefully this revealjs change will solves tooltip issue for all the JS lib in revealjs slides 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version use
zoomattributes which messes up JS lib like plotly. This new version usingscale()transform only.This fixes #2430
Steps were
update-html-dependenciesfor reveal to use commit instead of tagsquarto-bld.cmd update-html-dependenciesTested using version built with
./configure.cmdusing example in the issue. The tooltip issue disappeared.I made a PR so that it is easier to test, I don't know if we want to update to a commit, or wait for a next release of Revealjs.
Feel free to dismiss if it is not desired now.