Remove ExecuTorch copy of Vectorized #7042
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7042
Note: Links to docs will display an error until the docs builds have been completed. ❌ 70 New Failures, 1 Unrelated FailureAs of commit 7b16758 with merge base df75088 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Nov 23, 2024
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
swolchok
added a commit
that referenced
this pull request
Nov 23, 2024
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) ghstack-source-id: 255095942 Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 23, 2024
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 255100702 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
swolchok
added a commit
that referenced
this pull request
Nov 23, 2024
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 255101543 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
swolchok
added a commit
that referenced
this pull request
Nov 26, 2024
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 255547405 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Dec 2, 2024
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 256068820 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Dec 2, 2024
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 256078544 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Dec 8, 2024
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 257038888 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
swolchok
added a commit
that referenced
this pull request
Dec 17, 2024
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 258553931 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
swolchok
added a commit
that referenced
this pull request
Jan 30, 2025
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 263892114 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
swolchok
added a commit
that referenced
this pull request
Jan 30, 2025
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 263918323 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
swolchok
added a commit
that referenced
this pull request
Jan 30, 2025
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 263944262 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
swolchok
added a commit
that referenced
this pull request
Jan 30, 2025
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 263951677 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
swolchok
pushed a commit
that referenced
this pull request
Feb 4, 2025
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 263951677 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
swolchok
pushed a commit
that referenced
this pull request
Feb 4, 2025
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 263951677 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
swolchok
pushed a commit
that referenced
this pull request
Feb 6, 2025
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 265150327 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
kimishpatel
approved these changes
Feb 6, 2025
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66396016 |
swolchok
pushed a commit
that referenced
this pull request
Feb 7, 2025
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 265190626 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
swolchok
commented
Feb 7, 2025
| @@ -1,51 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
hey @dbort does our bc policy require me to undelete all these files? saw you mentioned it recently but I don't know the exact text of the policy
There was a problem hiding this comment.
Policy is at https://pytorch.org/executorch/main/api-life-cycle.html
The goal of the policy is to avoid breaking user code that worked with the previous release. Removing a header could break code that currently works.
Looking at the files that this PR changes, I'm not totally sure if they really qualify as part of our public API; not sure if the headers under kernels/... are meant to be used outside the repo or if they're just for the code around them.
There was a problem hiding this comment.
It could be if they are used to author custom ops out of the repo, but 1) I havent seen any examples in the wild and 2) I dont know if we package this header in our pip package (like pytorch) OR make it public somehow
There was a problem hiding this comment.
haven't seen any examples in the wild
I searched GitHub and found nothing after pruning paths within ExecuTorch and forks.
All uses are outside ExecuTorch core, so we can just use ATen Vectorized. Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Apr 28, 2025
Pull Request resolved: #7042 All uses are outside ExecuTorch core, so we can just use ATen Vectorized. ghstack-source-id: 280756645 @exported-using-ghexport Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
|
This will require pytorch/pytorch#152366 to be included in a pin bump before landing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: D66396016