-
Notifications
You must be signed in to change notification settings - Fork 545
[Build] Implement install_requirements.sh with Python #4748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4748
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit dd5b83e with merge base d3da92d ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Tested install_requirements.py under WSL and native Windows only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! Thank you so much for taking the time to do this. It'll be great to reduce the duplication between windows and non-windows.
Move the details of install_requirements.sh into install_requirements.py. Then, call install_requirements.py from install_requirements.sh. This will avoid duplication when add Windows version of installing_requirements. This is for issue pytorch#4661.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! This looks great. I'll try running it locally when I have a chance.
Worked for me on mac. I updated the PR summary with the steps that I followed. I'm waiting for jobs to finish, but I should be able to merge this soon. |
Undid the nightly string change at @lucylq's request; we're not ready to bump it yet. |
I just removed the date-changing commit from this PR, going back to a previous state that's already been tested. Merging. |
Thank you again for doing this @python3kgae! This is something we've wanted to do for a while, and it really helps cut down on the duplication when making it work for Windows. |
Thank you for the review and testing. We are now closer to achieving a native Windows build. |
Move the details of install_requirements.sh into install_requirements.py. Then, call install_requirements.py from install_requirements.sh.
This will avoid duplication when adding Windows version of installing_requirements.
This is for issue #4661.
Release Note: Moved the main install_requirements.sh logic into install_requirements.py so that it can also run on Windows.
Test Plan:
Tested on a mac.
Ran
./install_requirements.sh --pybind xnnpack
under python 3.10, and it completed successfully. To make sure that xnnpack was actually installed, I manually ran the steps from the notebook at https://colab.research.google.com/drive/1qpxrXC3YdJQzly3mRg-4ayYiOjC6rue3, and it passed.When running the same in a clean python 3.8 environment, it failed as expected with
Also tested under WSL and native Windows.