-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Remove stubs for characteristic
?
#8012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't think we should necessarily remove stubs for unmaintained packages, since people may still use them and providing types could provide a valuable service. Even if the package only declares support for Python 3.3-3.4, it may still work fine on newer versions. In this case though, I think it's fine to remove, since there's been little interest in the stubs since they were contributed in #771, and the package has been unmaintained for so long. |
That said, I have no objections with removing it. The types package remains, after all, we just can't update it easily. Cc @hynek as author. We could add another field, similar to |
I wasn't suggesting going on a blitz to remove all unmaintained packages from typeshed — I was just looking at the source code for this one for another reason, and was struck by the warning on the GitHub homepage :)
+1 to both of these thoughts. |
For me the question is mostly about how useful those stubs are at all? Since it's attrs-like, you rather need a plugin for it to be useful with mypy? The last release is 8 years ago, I had no idea that stubs actually exist, and it has only 30k downloads per month (which is suspect are only mirrors). So I have no hard feelings if y'all dropped them. |
The
characteristic
library hasn't had any changes since October 2020. It also has a big warning on its GitHub homepage saying:It doesn't seem like we've had any issues or PRs relating to these stubs for a long time. Should we remove them?
(Side note: I'm not sure what our policy is for removing stubs for unmaintained libraries that don't have type hints -- we don't have anything in
CONTRIBUTING.md
.)The text was updated successfully, but these errors were encountered: