Skip to content

Infra: Declare Makefile targets as phony #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,27 +6,35 @@ JOBS=8
OUTPUT_DIR=build
RENDER_COMMAND=$(VENVDIR)/bin/python3 build.py -j $(JOBS) -o $(OUTPUT_DIR)

.PHONY: render
render: venv
$(RENDER_COMMAND)

.PHONY: pages
pages: venv rss
$(RENDER_COMMAND) --build-dirs

.PHONY: fail-warning
fail-warning: venv
$(RENDER_COMMAND) --fail-on-warning

.PHONY: check-links
check-links: venv
$(RENDER_COMMAND) --check-links

.PHONY: rss
rss: venv
$(VENVDIR)/bin/python3 generate_rss.py

.PHONY: clean
clean: clean-venv
-rm -rf build topic

.PHONY: clean-venv
clean-venv:
rm -rf $(VENVDIR)

.PHONY: venv
venv:
@if [ -d $(VENVDIR) ] ; then \
echo "venv already exists."; \
Expand All @@ -38,13 +46,16 @@ venv:
echo "The venv has been created in the $(VENVDIR) directory"; \
fi

.PHONY: lint
lint: venv
$(VENVDIR)/bin/python3 -m pre_commit --version > /dev/null || $(VENVDIR)/bin/python3 -m pip install pre-commit
$(VENVDIR)/bin/python3 -m pre_commit run --all-files

.PHONY: test
test: venv
$(VENVDIR)/bin/python3 -bb -X dev -W error -m pytest

.PHONY: spellcheck
spellcheck: venv
$(VENVDIR)/bin/python3 -m pre_commit --version > /dev/null || $(VENVDIR)/bin/python3 -m pip install pre-commit
$(VENVDIR)/bin/python3 -m pre_commit run --all-files --hook-stage manual codespell