Fix joining of fixed-length tuples with mismatching lengths #8333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
force-pushed
the
join-mismatching-length-fixed-tuples
branch
2 times, most recently
from
e4900ba to
0bc852b
Compare
intgr
changed the title
intgr
force-pushed
the
join-mismatching-length-fixed-tuples
branch
from
0bc852b to
c7b9a46
Compare
This was referenced Jan 26, 2020
Closed
|
Thanks! Looks good. Maybe also add simple data-driven test (in |
intgr
force-pushed
the
join-mismatching-length-fixed-tuples
branch
2 times, most recently
from
e5c1e86 to
5263a51
Compare
|
I discovered some awkward behavior when attempting to create a sub-subclass of from typing import Tuple, NamedTuple
class NTup1(NamedTuple):
a: bool
class NTup2(NTup1):
b: bool
tup1 = None # type: NTup1
tup2 = None # type: NTup2
tup1 = tup2 # This should be an error, a 2-tuple type is not compatible with 1-tuple
def bla(x: NTup1): ...
bla(tup2) # This should be an error, a 2-tuple type is not compatible with 1-tuple |
|
Pushed additional tests. Is this what you had in mind? |
intgr
force-pushed
the
join-mismatching-length-fixed-tuples
branch
from
5263a51 to
ffded6b
Compare
|
Rebased after conflicts from merging #8335. |
intgr
force-pushed
the
join-mismatching-length-fixed-tuples
branch
2 times, most recently
from
e1e1333 to
ed011c3
Compare
For example: Tuple[bool, int] + Tuple[bool] becomes Tuple[int, ...] Previously Mypy simply punted and returned `object`. The handling of fixed tuple + variadic tuple will be implemented separately.
intgr
force-pushed
the
join-mismatching-length-fixed-tuples
branch
from
ed011c3 to
c2a1971
Compare
Could you file a separate issue about this? |
sthagen
added a commit
to sthagen/python-mypy
that referenced
this pull request
Feb 3, 2020
Fix joining of fixed-length tuples with mismatching lengths (python#8333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
Tuple[bool, int] + Tuple[bool]becomesTuple[int, ...]Previously Mypy simply punted and returned
object.This solves part of #4975. The other missing handling of fixed tuple + variadic tuple will be implemented separately, if this PR goes well. :)