Skip to content

Report an error if final class has abstract attributes #8332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 26, 2020
Merged

Report an error if final class has abstract attributes #8332

merged 5 commits into from
Jan 26, 2020

Conversation

dhalenok
Copy link
Contributor

Closes #8316.

ilevkivskyi
ilevkivskyi reviewed Jan 25, 2020
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please add tests for this? Also a tiny docs update would be good.

@dhalenok
Copy link
Contributor Author

dhalenok commented Jan 25, 2020 •
edited
Loading

@ilevkivskyi Sure!
Since I'm new to contributing to mypy, could you give me a little hint on where the tests would go?

@ilevkivskyi
Copy link
Member

Probably in test-data/unit/check-classes.test

@dhalenok dhalenok requested a review from ilevkivskyi January 26, 2020 14:05
ilevkivskyi
ilevkivskyi reviewed Jan 26, 2020
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updates! I have few suggestions.

@ilevkivskyi ilevkivskyi merged commit be883f6 into python:master Jan 26, 2020
@dhalenok dhalenok deleted the 8316 branch January 26, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Disallow final classes from having abstract methods or properties
2 participants
@dhalenok @ilevkivskyi