mypy_primer: truncate per-project output #14091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ikonst
force-pushed
the
2022-11-14-mypy_primer_per_project_limit
branch
from
b8d1849 to
bebf0ad
Compare
This comment has been minimized.
This comment has been minimized.
|
Hmm, that's not right... ^ |
|
I think maybe the last commit didn't trigger mypy_primer at all, due to the fact that there's now a merge conflict :) |
|
So it didn't trigger the primer run but triggered the merging? |
|
OK, conflict was in tests, resolved the conflict in some random way. |
This comment has been minimized.
This comment has been minimized.
|
IIRC you're not going to be able to test this in a PR to mypy, unfortunately. The comment workflow requires additional perms, so I believe it doesn't actually run the code in this PR. You could get it to run on your fork though! |
|
@hauntsaninja Thanks for the tip, makes perfect sense. I'm only starting to grok the security model of Actions. Let's try: ikonst#1 |
|
@hauntsaninja tested here |
ikonst
force-pushed
the
2022-11-14-mypy_primer_per_project_limit
branch
from
d00fa42 to
15eeecd
Compare
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14059.