Remove show_none_errors and strict_optional_whitelist #13507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are somewhat buggy and modern per-module options should be preferred. I can't find any use of strict_optional_whitelist. There is some use of show_none_errors, but it's all set to True; I think people are just worried and cargo culting and want mypy to really, actually give them all the errors. Fixes python#6514, fixes python#2396
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hauntsaninja
added a commit
to hauntsaninja/dragonchain
that referenced
this pull request
Aug 25, 2022
`show_none_errors` is deprecated, see python/mypy#13507
hauntsaninja
added a commit
to hauntsaninja/pandas
that referenced
this pull request
Aug 25, 2022
`show_none_errors` is deprecated, see python/mypy#13507
hauntsaninja
added a commit
to hauntsaninja/stone
that referenced
this pull request
Aug 25, 2022
`show_none_errors` is deprecated, see python/mypy#13507
hauntsaninja
added a commit
to hauntsaninja/PathPicker
that referenced
this pull request
Aug 25, 2022
`show_none_errors` is deprecated, see python/mypy#13507
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sobolevn
approved these changes
Aug 25, 2022
|
I already made PRs, see the links^ |
|
Diff from mypy_primer, showing the effect of this PR on open source code: dragonchain (https://github.com/dragonchain/dragonchain)
+ mypy.ini: [mypy]: Unrecognized option: show_none_errors = True
pandas (https://github.com/pandas-dev/pandas)
+ pyproject.toml: [mypy]: Unrecognized option: show_none_errors = True
stone (https://github.com/dropbox/stone)
+ mypy.ini: [mypy]: Unrecognized option: show_none_errors = True
|
JukkaL
approved these changes
Aug 25, 2022
twoertwein
pushed a commit
to pandas-dev/pandas
that referenced
this pull request
Sep 3, 2022
Remove use of deprecated mypy option `show_none_errors` is deprecated, see python/mypy#13507
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Remove use of deprecated mypy option `show_none_errors` is deprecated, see python/mypy#13507
Jasha10
pushed a commit
to Jasha10/PathPicker
that referenced
this pull request
Nov 2, 2023
`show_none_errors` is deprecated, see python/mypy#13507
KapJI
pushed a commit
to facebook/PathPicker
that referenced
this pull request
Sep 5, 2024
`show_none_errors` is deprecated, see python/mypy#13507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are somewhat buggy and modern per-module options should be
preferred. I can't find any use of strict_optional_whitelist.
There is some use of show_none_errors, but it's all set to True;
I think people are just worried and cargo culting and want mypy to
really, actually give them all the errors.
Fixes #6514, fixes #2396