[mypyc] Raise AttributeError also for non-refcounted types #11940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…butes Previously we only raised it for refcounted types, potentially resulting in errors like this: ``` SystemError: initialization of m failed without raising an exception ``` Unfortunately, this slows down the richards benchmark by about 15%. We can get the lost performance back once we have support for always defined attributes, at the latest.
|
LGTM |
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
) Previously we only raised it for refcounted types, potentially resulting in errors like this: ``` SystemError: initialization of m failed without raising an exception ``` Unfortunately, this slows down the richards benchmark by about 15%. We can get the lost performance back once we have support for always defined attributes, at the latest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only raised it for refcounted types when an attribute was
undefined, potentially resulting in errors like this:
Unfortunately, this slows down the richards benchmark by about 15%. We
can get the lost performance back once we have support for always
defined attributes, at the latest.