-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
add test for new union syntax on generic bounds #11431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you very much! :-)
@hauntsaninja i'm not sure why the 3.10 tests are failing because it works when i run the same code locally. i assume 3.9 and below are failing because this new union syntax is only enabled in 3.10, so i moved the test to the newly created |
This looks like a fixture issue to me. You may need a different one. See https://github.com/python/mypy/blob/master/test-data/unit/README.md#fixtures for an intro to fixtures. |
i can't seem to find a fixture that works, i thought maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! 👍
closes #10949