Skip to content

gh-95285: py.exe launcher fails with short argv0 #95295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 26, 2022
Merged

gh-95285: py.exe launcher fails with short argv0 #95295

merged 4 commits into from
Jul 26, 2022

Conversation

zooba
Copy link
Member

@zooba zooba commented Jul 26, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jul 26, 2022
@zooba zooba marked this pull request as ready for review July 26, 2022 19:33
@zooba zooba requested a review from a team as a code owner July 26, 2022 19:33
@zooba zooba merged commit 7ac5bb3 into python:main Jul 26, 2022
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@zooba zooba deleted the gh95285 branch July 26, 2022 20:24
@miss-islington
Copy link
Contributor

Sorry @zooba, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7ac5bb3e6a1cf780aea8164fdba09db993a21d6f 3.11

@zooba zooba added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jul 26, 2022
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2022
@zooba @miss-islington
pythongh-95285: py.exe launcher fails with short argv0 (pythonGH-95295)
577607f 
(cherry picked from commit 7ac5bb3)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 26, 2022
@bedevere-bot
Copy link

GH-95298 is a backport of this pull request to the 3.11 branch.

pfmoore
pfmoore approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol you beat me to it, I can confirm this appears to fix my issue.

ambv pushed a commit that referenced this pull request Jul 27, 2022
@miss-islington @zooba
gh-95285: py.exe launcher fails with short argv0 (GH-95295) (GH-95298)
7df3a1c 
(cherry picked from commit 7ac5bb3)

Co-authored-by: Steve Dower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfmoore pfmoore pfmoore approved these changes

Assignees

@zooba zooba

Labels
OS-windows tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @miss-islington @bedevere-bot @pfmoore