[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.12 (GH-31891) #31998
Conversation
Lib/asynchat.py
Outdated
| @@ -48,6 +48,13 @@ | |||
| import asyncore | |||
| from collections import deque | |||
|
|
|||
| from warnings import warn | |||
There was a problem hiding this comment.
We can't backport warnings like this, only documentation.
There was a problem hiding this comment.
Thanks, dropped changes to .py files, and adjusted the NEWS entry to refer only to docs (and not deprecation warnings).
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…12 (pythonGH-31891) Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594.. (cherry picked from commit 7747384) Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
force-pushed
the
backport-7747384-3.9
branch
from
66e6bbf to
5419793
Compare
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
|
@brettcannon: Please replace |
…12 (pythonGH-31891) (python#31998) Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594.. (cherry picked from commit 7747384) Co-authored-by: Hugo van Kemenade <[email protected]>
Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594.
(cherry picked from commit 7747384)
Also updated tests to ignore the (new in 3.9) deprecation warnings, the same way they're ignored in 3.10.
https://bugs.python.org/issue47022