bpo-44572: On Windows platform disconnect STDIN in platform._syscmd_ver() to prevent erroneous STDIN consumption #27092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er() to prevent erroneous STDIN consumption
|
Thanks for the pull request! The only thing left is to add the NEWS entry, which should be straightforward for you to click on its "Details" link and fill out. The description will be under the Windows section, so just a line like |
zooba
added
needs backport to 3.9
|
Thanks @Konstantin-Glukhov for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Thanks @Konstantin-Glukhov for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-27124 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 13, 2021
…prevent erroneous STDIN consumption (pythonGH-27092) (cherry picked from commit 0ee0a74) Co-authored-by: Konstantin-Glukhov <[email protected]>
|
GH-27125 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 13, 2021
…prevent erroneous STDIN consumption (pythonGH-27092) (cherry picked from commit 0ee0a74) Co-authored-by: Konstantin-Glukhov <[email protected]>
pablogsal
pushed a commit
that referenced
this pull request
Jul 13, 2021
…prevent erroneous STDIN consumption (GH-27092) (GH-27124) (cherry picked from commit 0ee0a74) Co-authored-by: Konstantin-Glukhov <[email protected]>
zooba
pushed a commit
that referenced
this pull request
Jul 14, 2021
…prevent erroneous STDIN consumption (GH-27092) (cherry picked from commit 0ee0a74) Co-authored-by: Konstantin-Glukhov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If script.py contains a call to platform.win32* functions the following invocation
inadvertently consumes STDIN redirected from file:
python.exe script.py < file
To address the issue, stdin=subprocess.DEVNULL argument needs to be added to subprocess.check_output() call in platform._syscmd_ver().
https://bugs.python.org/issue44572