closes bpo-39953: Update OpenSSL error codes table. #19082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
reviewed
Mar 20, 2020
Modules/_ssl_data.h
Outdated
Comment on lines
137
to
141
| #ifdef PEM_R_UNSUPPORTED_CIPHER | ||
| {"UNSUPPORTED_CIPHER", ERR_LIB_PEM, PEM_R_UNSUPPORTED_CIPHER}, | ||
| #else | ||
| {"UNSUPPORTED_CIPHER", ERR_LIB_PEM, 113}, | ||
| #endif |
There was a problem hiding this comment.
Hmmm this error was accurate..., pem unsupported cipher value is 113 too.
Is this removed because we can't detect the source of error and 113 (ssl source) is invalid configuration?
Contrast this change with the change for error 112 which is kept at pem source and also updated at ssl source.
I updated the error codes using the OpenSSL 1.1.1f source tree.
|
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 11, 2020
I updated the error codes using the OpenSSL 1.1.1f source tree. (cherry picked from commit 3e0dd37) Co-authored-by: Benjamin Peterson <[email protected]>
|
GH-19478 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Apr 11, 2020
I updated the error codes using the OpenSSL 1.1.1f source tree. (cherry picked from commit 3e0dd37) Co-authored-by: Benjamin Peterson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the error codes using the OpenSSL 1.1.1f source tree.
https://bugs.python.org/issue39953