gh-133157: remove use of _Py_NO_SANITIZE_UNDEFINED in faulthandler
#134047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reading from NULL is no more an undefined behavior for C11 - instead of using 1/0 arithmetic, we explicitly raise SIGFPE
vstinner
reviewed
May 15, 2025
vstinner
reviewed
May 15, 2025
picnixz
commented
May 15, 2025
Reading from NULL is an undefined behavior and `faulthandler` should not check for low-level C about undefined behaviors.
|
Should I actually add a NEWS entry? the function was not documented but it had a docstring. |
It doesn't need a NEWS entry since it's a private function written for test_faulthandler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_read_null()as it's a tricky one (and the compiler didn't seem to complain)