Skip to content

gh-63882: Break down and tests in test_minidom #133026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Apr 26, 2025

First part, up to 750 lines. Continues my previous work.

Did these by hand, they should be all right now ;-)

request: @picnixz @hugovk

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Apr 26, 2025
@picnixz picnixz changed the title gh-63882: Use self.assert* in test_minidom gh-63882: Break down and tests in test_minidom Apr 26, 2025
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hugovk hugovk added the needs backport to 3.13 bugs and security fixes label May 5, 2025
@hugovk hugovk enabled auto-merge (squash) May 5, 2025 15:54
@hugovk hugovk merged commit e294e16 into python:main May 5, 2025
50 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 5, 2025
…3026)

(cherry picked from commit e294e16)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 5, 2025

GH-133451 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 5, 2025
@StanFromIreland StanFromIreland deleted the minidom-750-up branch May 5, 2025 16:08
hugovk pushed a commit that referenced this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants