-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-120289: Add external timer in traverse of _lsprof.Profiler #121998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@colesbury maybe you could take a quick look at this? |
Thanks! |
Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…ythonGH-121998) (cherry picked from commit eaf094c) Co-authored-by: Tian Gao <[email protected]>
…ythonGH-121998) (cherry picked from commit eaf094c) Co-authored-by: Tian Gao <[email protected]>
GH-122000 is a backport of this pull request to the 3.13 branch. |
GH-122001 is a backport of this pull request to the 3.12 branch. |
|
It turned out that we did not include the external timer in
tp_traverse
, and the external timer could be a container that causes a ref cycle - this could lead to ref leak.Confirmed that
./python -m test -R3:3 test_cprofile
passed after the change.