Skip to content

gh-76785: Minor Improvements to "interpreters" Module #116328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Mar 4, 2024

This includes adding pickle support to various classes, and small changes in the low-level _xxinterpqueues module that improve maintainability.

@ericsnowcurrently ericsnowcurrently merged commit 4402b3c into python:main Mar 5, 2024
@ericsnowcurrently ericsnowcurrently deleted the interpreters-module-improvements branch March 5, 2024 15:54
@terryjreedy
Copy link
Member

New warnings when compile on Windows. I suspect from this PR since compiled yesterday.

f:\dev\3x\Modules\_xxinterpqueuesmodule.c(753,25): warning C4477: 'fprintf' : f
ormat string '%ld' requires an argument of type 'long', but variadic argument 1
 has type 'int64_t' [f:\dev\3x\PCbuild\pythoncore.vcxproj]
f:\dev\3x\Modules\_xxinterpqueuesmodule.c(761,25): warning C4477: 'fprintf' : f
ormat string '%ld' requires an argument of type 'long', but variadic argument 1
 has type 'int64_t' [f:\dev\3x\PCbuild\pythoncore.vcxproj]
f:\dev\3x\Modules\_xxinterpqueuesmodule.c(761,25): warning C4477: 'fprintf' : f
ormat string '%ld' requires an argument of type 'long', but variadic argument 2
 has type 'Py_ssize_t' [f:\dev\3x\PCbuild\pythoncore.vcxproj]

@ericsnowcurrently
Copy link
Member Author

I'll take a look.

ericsnowcurrently added a commit that referenced this pull request Mar 5, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
…-116328)

This includes adding pickle support to various classes, and small changes to improve the maintainability of the low-level _xxinterpqueues module.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…-116328)

This includes adding pickle support to various classes, and small changes to improve the maintainability of the low-level _xxinterpqueues module.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants