This repository was archived by the owner on Nov 23, 2017. It is now read-only.
SSL hangs if connection_lost is called (#472) #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were situations when yield from waiter hangs. For example if connection is aborted by peer before handshake completes.
|
Hello, and thanks for your contribution! Unfortunately our records indicate you have not signed a PSF contributor agreement (CLA). For legal reasons we need you to sign this before we can look at your contribution. Once you have done everything that's needed, please reply here and someone will verify everything is in order. |
|
@gvanrossum the code is correct and the bug is real and hard to debug: MagicStack/asyncpg#49. Can I merge this in 3.6.0 if Ned approves? @ned-deily |
|
There's going to be a 3.6.0rc2 tagged within the next 16 hours. If Guido approves the pull request, push it to the 3.6 branch and I'll cherrypick it. |
|
OK, approved. @1st1 Please merge into 3.6.0! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were situations when yield from waiter hangs. For example if connection is aborted by peer before handshake completes.