Add support for aiohttp.web
#571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @p1c2u I see you are the lead maintainer for this library. Just wanted to send a ping on this PR - let me know if I've missed any steps for contributing. |
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
+ Coverage 90.30% 90.36% +0.06%
==========================================
Files 124 127 +3
Lines 3682 3738 +56
Branches 442 454 +12
==========================================
+ Hits 3325 3378 +53
- Misses 302 303 +1
- Partials 55 57 +2
|
|
thank you for your contribution. It looks very good. We just need to add documentation for the integration. |
seandstewart
force-pushed
the
aiohttp-web-support
branch
from
e8a5712 to
d6e26fc
Compare
@p1c2u Done! Also rebased off of main. There were some changes to dependencies so I had to regenerate the lockfile. |
p1c2u
force-pushed
the
aiohttp-web-support
branch
from
470f8d2 to
5d6a246
Compare
|
|
Now it's good to go. @seandstewart thank you for your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
aiohttp.webResponseandRequestobjects.I made the explicit choice to require passing in the response body for validation, given it's an async operation to fetch it.