Skip to content

Add NullUnmarshaller #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Conversation

stephenfin
Copy link
Contributor

The value 'null' is allowed in OpenAPI 3.1.

The value 'null' is allowed in OpenAPI 3.1.

Signed-off-by: Stephen Finucane <[email protected]>
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #432 (cd6996c) into master (a2b31c9) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
+ Coverage   92.74%   92.83%   +0.09%     
==========================================
  Files         100      100              
  Lines        2411     2414       +3     
  Branches      304      305       +1     
==========================================
+ Hits         2236     2241       +5     
  Misses        131      131              
+ Partials       44       42       -2     
Impacted Files Coverage Δ
openapi_core/unmarshalling/schemas/factories.py 93.65% <100.00%> (+1.71%) ⬆️
...penapi_core/unmarshalling/schemas/unmarshallers.py 88.93% <100.00%> (+0.09%) ⬆️
openapi_core/unmarshalling/schemas/formatters.py 88.88% <0.00%> (+5.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@p1c2u p1c2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests. LGTM

@p1c2u p1c2u merged commit 7db11f4 into python-openapi:master Oct 10, 2022
@stephenfin
Copy link
Contributor Author

Thanks. Could you release a 0.16.2 with this include, please? 🙏

@stephenfin stephenfin deleted the null-unmarshaller branch October 11, 2022 10:08
@p1c2u
Copy link
Collaborator

p1c2u commented Oct 11, 2022

@stephenfin I will release it with multi type unmarshaller soon.

stephenfin added a commit to getpatchwork/patchwork that referenced this pull request Dec 6, 2022
openapi-core 0.16.2 includes support for null values [1]. We need this
to fix our CI.

[1] python-openapi/openapi-core#432

Signed-off-by: Stephen Finucane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants