Skip to content

p1c2u/openapi-core#296: Adds support for OpenAPI 3.1 #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nezhar
Copy link
Contributor

@nezhar nezhar commented Aug 30, 2021

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #373 (4005f78) into master (51fa9cd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          80       80           
  Lines        1824     1824           
  Branches      273      273           
=======================================
  Hits         1747     1747           
  Misses         57       57           
  Partials       20       20           
Impacted Files Coverage Δ
openapi_core/spec/shortcuts.py 90.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51fa9cd...4005f78. Read the comment docs.

@nezhar nezhar force-pushed the master branch 2 times, most recently from 557c70f to 4ed37e3 Compare November 3, 2021 16:42
@nezhar nezhar marked this pull request as ready for review November 30, 2021 17:48
@tschmidtb51
Copy link

@p1c2u Could you please add your review?

@p1c2u
Copy link
Collaborator

p1c2u commented Jan 19, 2022

Python 3.6 support drop can be extracted to separate commit/PR

@p1c2u
Copy link
Collaborator

p1c2u commented Jan 19, 2022

We need to add information about supported versions and how to use them to the README file

@nezhar
Copy link
Contributor Author

nezhar commented Jan 21, 2022

Python 3.6 support drop can be extracted to separate commit/PR

Moved it to #383

@nezhar nezhar force-pushed the master branch 5 times, most recently from 18270c8 to 4e3f0be Compare January 28, 2022 14:48
@nezhar
Copy link
Contributor Author

nezhar commented Jan 28, 2022

This is now using openapi-schema-validator==0.3.0a1 and openapi-spec-validator==0.5.0a1.

As openapi_v3_spec_validator is referencing to openapi_v31_spec_validator with the new alpha release, all tests for 3.0 specs need to explicitly define the spec_validator in the create_spec function.

Example:

from openapi_spec_validator import openapi_v31_spec_validator

spec = create_spec(
    spec_dict, spec_uri, spec_validator=openapi_v30_spec_validator
)

@nezhar
Copy link
Contributor Author

nezhar commented Mar 15, 2022

@p1c2u are there any plans to continue with this or is it heading in a wrong direction? I'm asking, because since #393 was merged, there are a few things that need to be adapted in the PR.

stephenfin added a commit to getpatchwork/patchwork that referenced this pull request May 6, 2022
This will be fixed in a future openapi-core release [1]. Indicate as
much.

[1] python-openapi/openapi-core#373

Signed-off-by: Stephen Finucane <[email protected]>
@p1c2u
Copy link
Collaborator

p1c2u commented Sep 12, 2022

Closing in favor of #419

@p1c2u p1c2u closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants