Skip to content

Bugfix 311 falcon get media error #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BontaVlad
Copy link

Fixes #311. Makes openapi-core compatible with falcon 3.0.0

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #316 (74d49d1) into master (0865a4f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   96.82%   96.84%   +0.02%     
==========================================
  Files         126      127       +1     
  Lines        2489     2507      +18     
==========================================
+ Hits         2410     2428      +18     
  Misses         79       79              
Impacted Files Coverage Δ
openapi_core/contrib/falcon/compat.py 100.00% <100.00%> (ø)
openapi_core/contrib/falcon/handlers.py 100.00% <100.00%> (ø)
openapi_core/contrib/falcon/requests.py 100.00% <100.00%> (ø)
openapi_core/contrib/falcon/responses.py 91.66% <100.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0865a4f...74d49d1. Read the comment docs.

@BontaVlad
Copy link
Author

Friendly reminder @p1c2u

@p1c2u p1c2u force-pushed the bugfix-311-falcon-get-media-error branch from 8e800b5 to 74d49d1 Compare April 30, 2021 23:49
Copy link
Collaborator

@p1c2u p1c2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor changes and run tests against falcon3 LGTM

@p1c2u
Copy link
Collaborator

p1c2u commented May 1, 2021

@BontaVlad thank you for the contribution

@p1c2u p1c2u merged commit c23f9fe into python-openapi:master May 1, 2021
@BontaVlad
Copy link
Author

@p1c2u thank you for all the hard work you put into maintaining this opensource project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is openapi_core compatible with falcon 3.0.0?
2 participants