Skip to content

Format checker on validation scope #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Feb 13, 2021

Format checker cached in validator object. Should improve unmarshalling performance for many requests. Fixes #289

@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #292 (90355f8) into master (70f05b2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   96.74%   96.75%           
=======================================
  Files         122      122           
  Lines        2429     2436    +7     
=======================================
+ Hits         2350     2357    +7     
  Misses         79       79           
Impacted Files Coverage Δ
openapi_core/unmarshalling/schemas/factories.py 100.00% <100.00%> (ø)
openapi_core/unmarshalling/schemas/util.py 90.62% <100.00%> (+4.91%) ⬆️
openapi_core/validation/validators.py 93.54% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70f05b2...90355f8. Read the comment docs.

@p1c2u p1c2u merged commit 5673e8f into master Feb 13, 2021
@p1c2u p1c2u deleted the fix/format-checker-on-validator-scope branch February 13, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_validator takes too much time
1 participant