Small change to Schema model to allow generated specs to be picklable #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- overriding __dict__ is death for pickling. I renamed it to __newdict__ and tweaked the one user of it, and now this part of the structure is working fine for pickling - there are also upstream changes in jsonschema that need to be in for the overall success - this allows me to create the API spec from a swagger file once (which takes 2-20s for the files I'm working with), and cache the result as a pickle file for loading on the next startup (assuming the swagger file hasn't been updated). The load from pickle files takes 2-5ms. This is an improvement of load time by 3 orders of magnitude.
Merge from upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and tweaked the one user of it, and now this part of the structure is
working fine for pickling
overall success
2-20s for the files I'm working with), and cache the result as a pickle file
for loading on the next startup (assuming the swagger file hasn't been
updated). The load from pickle files takes 2-5ms. This is an improvement
of load time by 3 orders of magnitude.