Skip to content

Move deserialize/cast out of schema models #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 3, 2020

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Feb 3, 2020

  • Split cast and deserialise processes
  • get rid of InvalidParameterValue exceptions from casting process. Now it returns original CastError exception
  • Move value getters out of schema models
  • get rid of InvalidMediaTypeValue exception from deserializing process. Now it returns original DeserializeError exception

Fixes #175

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #191 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   96.35%   96.20%   -0.15%     
==========================================
  Files          97      103       +6     
  Lines        1948     1978      +30     
==========================================
+ Hits         1877     1903      +26     
- Misses         71       75       +4     
Impacted Files Coverage Δ
...penapi_core/deserializing/media_types/factories.py 100.00% <0.00%> (ø)
openapi_core/deserializing/parameters/factories.py 100.00% <0.00%> (ø)
...penapi_core/deserializing/parameters/exceptions.py 85.71% <0.00%> (ø)
...pi_core/deserializing/media_types/deserializers.py 100.00% <0.00%> (ø)
openapi_core/deserializing/exceptions.py 87.50% <0.00%> (ø)
...api_core/deserializing/parameters/deserializers.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1a6c1...4044483. Read the comment docs.

@p1c2u p1c2u changed the title Move cast out of schema models Move deserialize/cast out of schema models Feb 3, 2020
@p1c2u p1c2u force-pushed the refactor/move-cast-out-of-schema-models branch 2 times, most recently from d27ec34 to e063759 Compare February 3, 2020 14:51
@p1c2u p1c2u force-pushed the refactor/move-cast-out-of-schema-models branch from e063759 to 4044483 Compare February 3, 2020 14:55
@p1c2u p1c2u merged commit 8048578 into master Feb 3, 2020
@p1c2u p1c2u deleted the refactor/move-cast-out-of-schema-models branch February 3, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Why do validation errors raise InvalidMediaTypeValue?
1 participant